Convert mlab tests to pytest #7883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelleV
approved these changes
Jan 20, 2017
Member
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
I would much rather just changing the import. This migration is making the tests much harder to read.
It looks good.
NelleV
changed the title
AppVeyor doesn't install pytest, so the nose build fails with this one.
phobson
approved these changes
Jan 22, 2017
phobson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the single largest file with changes, simply because it's just so big anyway. But that means it can only get simpler from here. I have a feeling that some of these tests could be
parametrized, but it was large enough without such changes.The first commit, while the largest (just barely), is also the automated one, so it's probably safe.