Repository navigation
BUG: in Patch.update_from, use private variables. Closes #7375. - #7497
Merged
Merged
Conversation
efiring
changed the title
NelleV
changed the title
Member
Author
|
The failure is the usual random unrelated text-related variety. I think that a modification of test_cycles.test_fillcycle_basic can be made to directly test for the bug identified in #7375. |
tacaswell
approved these changes
Nov 22, 2016
tacaswell
changed the title
Member
|
Thanks! |
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the example in #7375 work correctly; let's see if it breaks anything in the tests.