Repository navigation
BUG: fix autoscale_view with log scale and margins - #7410
Merged
Merged
Conversation
LogLocator.view_limits was always clipping vmin to minpos; now it sets vmin to minpos only if vmin <= 0.
Member
Author
|
There are many failed tests because the test baseline images show the effects of the bug. I am fixing the images. |
efiring
added
the
Release critical
efiring
changed the title
Member
|
Thanks! This looks good. |
NelleV
changed the title
Member
|
Was there a ticket opened for this bug? It sorts of rings a bell… |
NelleV
approved these changes
Nov 5, 2016
Member
Author
|
Closes #6643. |
Merged
QuLogic
approved these changes
Nov 5, 2016
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
I don't really understand what minpos is supposed to represent, but all the test images certainly look better.
Member
Author
|
@Qlogic, minpos is the minimum positive value in the data. It is used to handle log scales applied to data that might include zero or negative values. |
Member
|
Thanks @efiring ! |
Member
|
wow, that is a major improvement! |
Member
Author
Kojoley
changed the title
This was referenced Nov 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogLocator.view_limits was always clipping vmin to minpos;
now it sets vmin to minpos only if vmin <= 0.