Repository navigation
FIX: LogLocator.set_params() was clobbering methods - #7045
Merged
Merged
Conversation
efiring
force-pushed
the
LogLocator_set_params_bug
branch
from
September 10, 2016 03:10
98708a8 to
7c9acc0
Compare
efiring
added
the
Release critical
Member
Author
|
@tacaswell, Sorry I didn't get this fixed earlier, in time for the last beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7043.
This is a quick and almost minimal fix. I left in a couple of cosmetic cleanups and a note about something else that should be changed, but that might cause a baseline image change, so I decided not to include it here.