Skip to content

Don't forget to disconnect callbacks for dragging. - #6808

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:dont-forget-to-disconnect-dragging-callbacks
Jul 22, 2016
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:dont-forget-to-disconnect-dragging-callbacks

Conversation

@anntzer

@anntzer anntzer commented Jul 21, 2016 •

Copy link
Copy Markdown
Contributor

Copy-pasted from #6785 (comment):

There's at least another issue with the DraggableBase code: the mouse move callback (._c1) does not get disconnected when .disconnect() is called (I tried explicitly calling .disconnect() to work around the above-mentioned issue, but I then get a crash upon moving the mouse because on_motion becomes invalid).

@tacaswell
tacaswell merged commit 3cb79ed into matplotlib:master Jul 22, 2016
@anntzer
anntzer deleted the dont-forget-to-disconnect-dragging-callbacks branch July 22, 2016 01:07
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 22, 2016
@QuLogic

QuLogic commented Sep 9, 2016

Copy link
Copy Markdown
Member

The original ticket is milestoned for 2.x, but this one isn't, or at least hasn't been backported. Maybe it should be?

tacaswell added a commit that referenced this pull request Sep 9, 2016
…ing-callbacks

FIX: Don't forget to disconnect callbacks for dragging.
@tacaswell

Copy link
Copy Markdown
Member

backported to v2.x as 85f6bfc

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release), 2.0.1 (next bug fix release) Sep 9, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants