Repository navigation
Clean up type checking in rex2txt (Fixes #5884) - #6396
Merged
Merged
Conversation
The main goal is to remove the reference to np.string0. In the end, it became better to clean up the checking of various types using np.issubdtype.
Member
|
we have a test_mlab.py?! amazing! |
Contributor
Author
|
Yeah--but had 0% test coverage on |
Contributor
Author
|
I'm out of practice--what should I do about this for master/2.0? |
Member
|
it'll get merged in during one of the regular merge-downs (about once a week). |
jarrodmillman
added a commit
to jarrodmillman/permute
that referenced
this pull request
Jul 27, 2016
Problem due to this bug: matplotlib/matplotlib#5884 1.5.2 includes the fix: matplotlib/matplotlib#6396 1.5.2 tagged release: matplotlib/matplotlib/releases/tag/v1.5.2 (also update numpy to current release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal is to remove the reference to np.string0. In the end, it became better to clean up the checking of various types using np.issubdtype.
This also gains things like better unicode handling and support for 128-bit float, for what it's worth. Given that it was completely broken on python3, I'm not convinced there were many users of this function.