Repository navigation
Conversation
Member
|
I am happy to merge this, but someone with a mac should probably test it. |
Contributor
Author
|
Btw, this pull request should not be back-ported. |
tacaswell
modified the milestones:
2.1 (next point release),
2.2 (next next feature release)
Member
|
Closing because the original issue #5251 is fixed in master and this never got merged or updated.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a comprehensive bug fix for issue #5251 . In particular, with this PR the backend is using the same code everywhere for the event loop, and the call to show() can be interrupted.