Repository navigation
Fix #3314 assert mods.pop(0) fails - #5387
Merged
Merged
Conversation
mods[0] does not contain the package name when installing via pip and running the multiprocess nose plugin. In the long term we should get rid of the namespace package
Member
Author
|
To be clear. This is more of a workaround that a fix. We could look into fixing this by debugging namespace packages but long term I think we should just get rid of namespace packages. |
Member
|
👍 -- I understand it's not a permanent solution, but better to get the permanent solution done when we eliminate the namespace package. |
tacaswell
added a commit
that referenced
this pull request
Nov 3, 2015
Fix #3314 assert mods.pop(0) fails
tacaswell
added a commit
that referenced
this pull request
Nov 3, 2015
Fix #3314 assert mods.pop(0) fails
Member
|
cherry-picked to v1.5.x as 1e4823b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mods[0] does not contain the package name when installing via pip and running the multiprocess nose plugin. In the long term we should get rid of the namespace package but for now we just pop it conditionally on the length of mods.