Repository navigation
Type kwargs as Any in plt.show - #32460
Merged
Merged
Conversation
This should prevent Pyright from raising "partially unknown" errors on calls to `plt.show`, as explained in matplotlib#27030. This is particularly annoying when writing Jupyter notebooks in Python format, which usually have many calls to `plt.show`.
iccir
approved these changes
Oct 10, 2026
iccir
left a comment
iccir
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me for now, although I believe the plan is to eventually use TypedDicts.
Contributor
Author
Anything that works is fine to me, but |
scottshambaugh
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This should prevent Pyright from raising "partially unknown" errors on calls to
plt.show, as explained in #27030. This is particularly annoying when writing Jupyter notebooks in Python format, which usually have many calls toplt.show.AI Disclosure
No AI was used.
PR quality check