Skip to content

DOC: Improve description of background/bbox handling for Text - #29875

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-text-bbox
Apr 7, 2025
Merged

timhoffm merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-text-bbox

Conversation

@timhoffm

@timhoffm timhoffm commented Apr 6, 2025

Copy link
Copy Markdown
Member

Inspired by #29874.

Comment thread lib/matplotlib/text.py
Parameters
----------
rectprops : dict with properties for `.patches.FancyBboxPatch`
rectprops : dict with properties for `.FancyBboxPatch` or None

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one should update the typing as well? If not, feel free to self merge.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@timhoffm
timhoffm force-pushed the doc-text-bbox branch 2 times, most recently from a2e8941 to cf3b329 Compare April 6, 2025 22:00
@timhoffm timhoffm added this to the v3.10.2 milestone Apr 7, 2025
@timhoffm
timhoffm merged commit cb9fcd6 into matplotlib:main Apr 7, 2025
@timhoffm
timhoffm deleted the doc-text-bbox branch April 7, 2025 00:13
@lumberbot-app

lumberbot-app Bot commented Apr 7, 2025

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 cb9fcd69afd61983cf2bedabba2ca257ab464298
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29875: DOC: Improve description of background/bbox handling for Text'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-29875-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #29875 on branch v3.10.x (DOC: Improve description of background/bbox handling for Text)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants