Repository navigation
Conversation
... and use `FontProperties.from_pattern()` instead. `FontProperties(pattern)` was an overloaded API that easily conflicts with `FontProperties(family)`. The parameter was assumed to be a pattern if it was a string and the only parameter.
timhoffm
force-pushed
the
FontProperties-pattern
branch
from
September 18, 2024 22:16
86f308d to
f63e438
Compare
Contributor
|
See also the item starting with "The FP constructor is a bit a mess..." at #10249, I guess. |
timhoffm
marked this pull request as draft
September 18, 2024 23:30
Member
Author
|
Sure. We could do
|
Contributor
In the single-arg case, I would try calling parse_fontconfig_pattern, then if it raises, treat as a family (and warn) (If it doesn't raise, this can also occur if the family and the pattern are identical, e.g. "Times" parses as {"family": "Times"}.) |
Member
Author
|
Superseeded by #28843. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and use
FontProperties.from_pattern()instead.FontProperties(pattern)was an overloaded API that easily conflicts withFontProperties(family). The parameter was assumed to be a pattern if it was a string and the only parameter.Noted in #28836 (review).