Repository navigation
Bug fix for Hatch linewidths in an rcParam context #21325 - #25367
rishavganguly007 wants to merge 6 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you for the PR. Please revert all the unrelated stylistic changes, as it is difficult to pin down what exactly you are changing here and they are all superfluous. This will also require adding some tests, I think. |
|
Hi @rishavganguly007 - there are still a couple of lines that are too long to pass our linter, could you check that so we can move forward with the review? Thanks! |
Hi @melissawm I have corrected the linting issue , but in the github test I can see still the flake8 test is failing for some whitespaces, |
|
Might be worth checking your flake8 installation - when I run In any case, you can use the CI as the source of truth here and fix those anyway. |
Thanks @melissawm , all the lint related issues has been fixed. |
|
Ok - it looks like now you have a few failed tests, can you take a look and see if those are related to your PR? |
|
@rishavganguly007 are you still interested in working on this one? |
|
I am going to close this one as it seems to have stalled. Closing will indicate to other contributors that they can pick up the issue. The patch is at #21108 (comment), so I think it will be at least as easy to start from there as it would be to rebase this branch. @rishavganguly007 if you are still interested in working on this, please do comment and we can re-open. |
PR Summary
Provided fix based on the sugesstions given for the issue #21108
PR Checklist
Documentation and Tests
pytestpasses)