Skip to content

Add tests for ToolManager #24184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 1 commit into from
Oct 19, 2022
Merged

Add tests for ToolManager #24184

QuLogic merged 1 commit into from
Oct 19, 2022

Conversation

@oscargus
Copy link
Member

@oscargus oscargus commented Oct 15, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm
timhoffm reviewed Oct 15, 2022
View reviewed changes
QuLogic
QuLogic reviewed Oct 17, 2022
View reviewed changes
timhoffm
timhoffm approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, provided @QuLogic comments are handled.

@QuLogic QuLogic merged commit 2770b45 into matplotlib:main Oct 19, 2022
@oscargus oscargus deleted the testbackendmanager branch October 19, 2022 07:54
@QuLogic QuLogic added this to the v3.6.2 milestone Oct 20, 2022
@QuLogic
Copy link
Member

QuLogic commented Oct 20, 2022

Forgot about the milestone.

@meeseeksdev backport to v3.6.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 20, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 20, 2022
@QuLogic @meeseeksmachine
Backport PR matplotlib#24184: Add tests for ToolManager
cddc066
timhoffm added a commit that referenced this pull request Oct 20, 2022
@timhoffm
Merge pull request #24223 from meeseeksmachine/auto-backport-of-pr-24…
0671809 
…184-on-v3.6.x

Backport PR #24184 on branch v3.6.x (Add tests for ToolManager)
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@oscargus @QuLogic @timhoffm