Repository navigation
Correct setup of margins for logarithmic plots - #2263
mowa-lepota wants to merge 3 commits into
Conversation
|
My concern about this code is that this would produce different results depending on whether the log scaling was set before or after the plotting command. Now, that is more an indictment against how we handle autoscaling rather than your code and so it probably shouldn't be a reason against including this. Note that you would most likely need to update test images, and if this change doesn't break any test images, then tests need to be added. |
|
Also, perhaps we should think about delegating the responsibility of determining such autoscaling over to the scales rather than what could potentially become a huge if/elif/else statement if more scales are supported. |
|
The domain of the axis is already determined by the scale's locator -- see the call to |
The current formula for setting margins is false in case of log plots. Here is a tested suggestion handling the special case. Please see if this can be backported to the current release candidate (perhaps even beyond), as it seems mandatory to have a correct way of setting margins for log plots.