Repository navigation
Replace sole use of maxdict by lru_cache. - #22323
Conversation
|
:) You can bring the deprecation over here if you want, happy to close the other PR. While you're at it, do you want to add a test here to make sure we are hitting the cache as expected since I made the mistake on the other one that would only cache on each text instance? |
|
Done (^2) |
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
All failures appear to be CI related.
| @@ -0,0 +1,4 @@ | |||
| ``matplotlib.cbook.maxdict`` is deprecated | |||
da764ff to
44d21ac
Compare
|
Edit: modified the implementation to not use pickle but instead key off an internally generated copy of fontprop (which the caller cannot access and thus cannot mutate). |
| # the passed-in argument do not mess up the cache. dpi is not used, but | ||
| # participates in cache invalidation (via the renderer). |
There was a problem hiding this comment.
| # the passed-in argument do not mess up the cache. dpi is not used, but | |
| # participates in cache invalidation (via the renderer). | |
| # the passed-in argument do not mess up the cache. |
Move that note down, because dpi is only passed on here. Clever tools will show unused in the function below and people might be tempted to remove it without consulting the context of the call site.
... and expand the cache size, while we're at it.
It was used in one place in the library and there is now a standard library lru_cache that we can take advantage of instead.
... and expand the cache size, while we're at it.
Actual deprecation of maxdict can be done in #22299.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).