Skip to content

Expire mathttext-related deprecations - #22107

Merged
QuLogic merged 2 commits into
matplotlib:mainfrom
oscargus:mathtext36
Jan 7, 2022
Merged

QuLogic merged 2 commits into
matplotlib:mainfrom
oscargus:mathtext36

Conversation

@oscargus

@oscargus oscargus commented Jan 5, 2022

Copy link
Copy Markdown
Member

PR Summary

Will add API-change information later on, but want to see how the tests work. (I have problem running things locally due to cyclic imports in main).

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@jklymak
jklymak marked this pull request as draft January 5, 2022 10:39
@jklymak

jklymak commented Jan 5, 2022

Copy link
Copy Markdown
Member

I made draft until this is ready.

@oscargus
oscargus force-pushed the mathtext36 branch 12 times, most recently from ca54adb to 3adce30 Compare January 5, 2022 17:08
Comment thread lib/matplotlib/tests/test_mathtext.py Resolved
@oscargus
oscargus marked this pull request as ready for review January 5, 2022 20:15
Comment thread lib/matplotlib/mathtext.py Resolved
Comment thread lib/matplotlib/tests/test_mathtext.py Resolved
@oscargus oscargus mentioned this pull request Jan 6, 2022
8 of 13 tasks
@timhoffm timhoffm added this to the v3.6.0 milestone Jan 6, 2022
@timhoffm timhoffm added the API: changes Changes to the public API, typically requiring deprecation. label Jan 6, 2022
@QuLogic
QuLogic merged commit d624571 into matplotlib:main Jan 7, 2022
@oscargus
oscargus deleted the mathtext36 branch January 7, 2022 22:15
HarshitZom added a commit to HarshitZom/matplotlib that referenced this pull request Nov 23, 2025
Prevent false deprecation warnings when empty arrays or lists are
passed to category unit converters (see matplotlib#22107). Empty data no longer
triggers warnings or conversion errors. Adds regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants