Repository navigation
Raise correct exception out of Spines.__getattr__ - #21570
Merged
Merged
Conversation
If the name does not exist, then `__getattr__` should raise `AttributeError`, not `ValueError`. Fixes matplotlib#21554
greglucas
approved these changes
Nov 9, 2021
greglucas
left a comment
greglucas
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but I'm not sure this closes the issue though. Now, we'll at least get the right error, but it still isn't a super helpful message for the user.
AttributeError: 'Spines' object does not contain a '__deepcopy__' spine
timhoffm
approved these changes
Nov 9, 2021
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
Approve for changing the error type.
It's however not a fix to the reported issue. deepcopy(figure) should not fail on some random internal state. Either we forbid it explicitly or somebody has to make it work with a reasonable meaning.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 9, 2021
This was referenced Nov 9, 2021
Merged
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 9, 2021
QuLogic
added a commit
that referenced
this pull request
Nov 9, 2021
…570-on-v3.5.x Backport PR #21570 on branch v3.5.x (Raise correct exception out of Spines.__getattr__)
QuLogic
added a commit
that referenced
this pull request
Nov 10, 2021
…570-on-v3.4.x Backport PR #21570 on branch v3.4.x (Raise correct exception out of Spines.__getattr__)
davidgegiya
added a commit
to davidgegiya/agent-orchestrator
that referenced
this pull request
Nov 8, 2026
Pin f0632c0fc7339f68e992ed63ae4cfac76cd41aad and its regression selectors for reproducible runs. Source: matplotlib/matplotlib#21570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
If the name does not exist, then
__getattr__should raiseAttributeError, notValueError.Fixes #21554
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).