Repository navigation
Fix make_norm_from_scale __name__ when used inline. - #21112
Merged
Merged
Conversation
`make_norm_from_scale` can be used "inline", rather than as a class decorator, to dynamically create norm classes. However, in that case, the second parameter (`base_norm_cls`) would normally be set to the root base norm class (`mcolors.Normalize`). In that case, we should generate a new `__name__` for the dynamically generated class, to avoid the slightly confusing situation of having two different classes both called `mcolors.Normalize`.
timhoffm
approved these changes
Sep 18, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 19, 2021
…n used inline.
story645
added a commit
that referenced
this pull request
Sep 19, 2021
…112-on-v3.5.x Backport PR #21112 on branch v3.5.x (Fix make_norm_from_scale `__name__` when used inline.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix make_norm_from_scale `__name__` when used inline.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix make_norm_from_scale `__name__` when used inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_norm_from_scalecan be used "inline", rather than as a classdecorator, to dynamically create norm classes. However, in that case,
the second parameter (
base_norm_cls) would normally be set to the rootbase norm class (
mcolors.Normalize). In that case, we shouldgenerate a new
__name__for the dynamically generated class, to avoidthe slightly confusing situation of having two different classes both
called
mcolors.Normalize.(See the "additional confusion" in the expected outcome section of #20755 (comment).)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).