Deprecate MarkerStyle(None).#21074
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Sep 16, 2021
Merged
Conversation
anntzer
force-pushed
the
msn2
branch
2 times, most recently
from
dc1e568 to
4df79be
Compare
dstansby
reviewed
Sep 15, 2021
lib/matplotlib/tests/test_axes.py
Outdated
Comment on lines
+4120
to
+4123
| for y, marker in enumerate([ | ||
| "none", | ||
| *sorted({*matplotlib.markers.MarkerStyle.markers} - {"none"}, | ||
| key=lambda x: str(type(x))+str(x))]): |
Member
There was a problem hiding this comment.
I tried but struggled to work out what's going on here with the change?
Contributor
Author
There was a problem hiding this comment.
The test simply draws all markers in a single figure, ordered by str(type(x))+str(x) (not all x have same type: markers can be str (most of them), but also int or, previously, None, hence the need to convert to str). A previous PR introduced MarkerStyle("none"), i.e. "none" was added into the MarkerStyle.markers dict; in order to not change the baseline image, I had to remove it from the list of entries. With this PR, I additionally removed None from the dict; again, in order to not change the baseline image, I had to put it back (using its synonym "none") into the list of entries (at the position where it was previously, i.e. in from of everything else).
Member
There was a problem hiding this comment.
I would write this as
markers = sorted(matplotlib.markers.MarkerStyle.markers,
key=lambda x: str(type(x))+str(x))
# Since generation of the test image, None was removed but 'none' was
# added. By moving 'none' to the front (=former sorted place of None)
# we can avoid regenerating the test image. This can be removed if the
# test image has to be regenerated for other reasons.
markers.remove('none')
markers = ['none', *markers]
for y, marker in enumerate(markers):
See docstring change for the confusion that this resolves. We can normalize None inputs on the caller side (and note that directly constructing MarkerStyles is not something that most users need to do).
dstansby
approved these changes
Sep 16, 2021
timhoffm
approved these changes
Sep 16, 2021
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Deprecate MarkerStyle(None).
EwoutH
added a commit
to quaquel/EMAworkbench
that referenced
this pull request
Oct 23, 2022
Fix two cases of the following deprecation:
MatplotlibDeprecationWarning: MarkerStyle(None) is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
See matplotlib/matplotlib#21074
EwoutH
added a commit
to quaquel/EMAworkbench
that referenced
this pull request
Oct 23, 2022
Fix two cases of the following deprecation:
MatplotlibDeprecationWarning: MarkerStyle(None) is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
See matplotlib/matplotlib#21074
EwoutH
added a commit
to quaquel/EMAworkbench
that referenced
this pull request
Oct 23, 2022
Fix two cases of the following deprecation:
MatplotlibDeprecationWarning: MarkerStyle(None) is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
See matplotlib/matplotlib#21074
EwoutH
added a commit
to quaquel/EMAworkbench
that referenced
this pull request
Oct 25, 2022
Fix two cases of the following deprecation:
MatplotlibDeprecationWarning: MarkerStyle(None) is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
See matplotlib/matplotlib#21074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See docstring change for the confusion that this resolves.
We can normalize None inputs on the caller side (and note that directly
constructing MarkerStyles is not something that most users need to do).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).