Skip to content

Cleanup installing docs - #19725

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
timhoffm:doc-installing
Mar 20, 2021
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
timhoffm:doc-installing

Conversation

@timhoffm

@timhoffm timhoffm commented Mar 17, 2021 •

Copy link
Copy Markdown
Member

PR Summary

  • Move "Installing from source" contents to it's own page to declutter the main installing page.
    The Installation FAQ should be merged in to the new "Installing from source" page, but that's for a separate PR.
  • Rewording.

Adresses part of #17327. Still to do is merging the Installation FAQ (see above).

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions, but overall seems great...

Comment thread INSTALL.rst Resolved
Comment thread INSTALL.rst Resolved
Comment thread INSTALL.rst Resolved
Comment thread INSTALL.rst Resolved
Comment thread INSTALL.rst Resolved
Comment thread doc/users/installing_source.rst Resolved
Comment thread doc/users/installing_source.rst Resolved

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but nothing blocking.

@timhoffm timhoffm added this to the v3.4-doc milestone Mar 20, 2021
@timhoffm

Copy link
Copy Markdown
Member Author

Self-merging based on @anntzer's approval.

@timhoffm
timhoffm merged commit 91cb8a8 into matplotlib:master Mar 20, 2021
@timhoffm
timhoffm deleted the doc-installing branch March 20, 2021 01:26
@jklymak jklymak mentioned this pull request Mar 22, 2021
7 tasks
@QuLogic

QuLogic commented Mar 26, 2021

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.4.0-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 26, 2021
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 26, 2021
QuLogic added a commit that referenced this pull request Mar 26, 2021
…725-on-v3.4.0-doc

Backport PR #19725/#19758 on branch v3.4.0-doc (Cleanup installing docs)
@SauravMaheshkar SauravMaheshkar mentioned this pull request Jan 4, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants