Repository navigation
Add option to create horizontally-oriented stem plots - #18187
Merged
Merged
Conversation
timhoffm
previously requested changes
Aug 8, 2020
timhoffm
reviewed
Aug 8, 2020
QuLogic
force-pushed
the
6168-vertical-stem
branch
from
August 11, 2020 05:04
4cd53fe to
b940f57
Compare
QuLogic
changed the title
timhoffm
reviewed
Aug 11, 2020
jklymak
reviewed
Aug 12, 2020
* Added docstrings for optional args in stem, made vertical default to false * Added flipping and renamed xs and ys in stem
Also modified documentation for the change. Flipped thisx to thisy and vice versa when the orientation value is vertical
Co-authored-by: Elliott Sales de Andrade <[email protected]>
They are no longer x/y when using a different orientation. Also, this should fix the unit conversion to use the correct Axis.
QuLogic
force-pushed
the
6168-vertical-stem
branch
from
August 13, 2020 03:44
b940f57 to
99e7ede
Compare
timhoffm
approved these changes
Aug 13, 2020
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
Optionally, use the suggested shorter what's new entry.
QuLogic
force-pushed
the
6168-vertical-stem
branch
from
August 14, 2020 05:15
99e7ede to
13d962a
Compare
jklymak
approved these changes
Aug 14, 2020
Member
|
CI doesn't pass, but its the MacOS problem not this PR |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a rebase and slight squash of #6168. It also fixes the documentation, style, and tests to match current practices.
Fixes #5856.
Closes #6168.
PR Checklist