Skip to content

DOCS: Remove How-to: Contributing - #17961

Merged
jklymak merged 3 commits into
matplotlib:masterfrom
timhoffm:doc-how-to-contributing
Aug 17, 2020
Merged

jklymak merged 3 commits into
matplotlib:masterfrom
timhoffm:doc-how-to-contributing

Conversation

@timhoffm

@timhoffm timhoffm commented Jul 18, 2020 •

Copy link
Copy Markdown
Member

PR Summary

Contributing is handled in the developer guide.

This PR removes the last "How-to: Contributing" section on documentation
and updates the section "Contributing documentation" in the developer
guide.

Follow-up to #17837 and #17842. Partly addresses #17920.

Comment thread doc/faq/howto_faq.rst
for it in the :ref:`users-guide-index`. And so on... I think you get the
idea.

Matplotlib is documented using the `sphinx

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mentioned anywhere else?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think most of this language would be great for a blog post, go back and forth about whether it should be shifted to the contributing docs section of contributing.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@story645 Are you referring to the complete section? IMHO this is too chatty for the docs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant about Sphinx, mostly. It could be a tiny bit more explicit, but yea I see it is in that page.

@story645 story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also jumping off what @efiring & @dopplershift said about keeping the FAQ around as a table of comments of sorts, should probably link out to the section that's being moved.

Comment thread doc/devel/contributing.rst Outdated
Comment on lines +301 to +304
We are continuously striving to improve our documentation. You as an end-user
of Matplotlib can a make valuable contribution to that because you will better
see the potentials for improvement compared to a core developer. These include
but are not limited to:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to do this directly like 15 times and get a 404, so:

You as an end-user of Matplotlib can make a valuable contribution because you better (more clearly?) see the potentials for improvement as compared to a core developer.

Comment thread doc/devel/contributing.rst Outdated
Comment on lines +311 to +312
The documentation lives in the same GitHub repository as the code.
Contributions are proposed and accepted though the pull request mechanism.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation source files live in the same Github repository as the code. Contributions are proposed and accepted through the pull request process

Comment thread doc/faq/howto_faq.rst
for it in the :ref:`users-guide-index`. And so on... I think you get the
idea.

Matplotlib is documented using the `sphinx

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think most of this language would be great for a blog post, go back and forth about whether it should be shifted to the contributing docs section of contributing.

Contributing is handled in the developer guide.

This PR removes the last "How-to: Contributing" section on documentation
and updates the section "Contributing documentation" in the developer
guide.
@timhoffm
timhoffm force-pushed the doc-how-to-contributing branch from 13ecc62 to d89f063 Compare July 22, 2020 21:19
@timhoffm

Copy link
Copy Markdown
Member Author

also jumping off what @efiring & @dopplershift said about keeping the FAQ around as a table of comments of sorts, should probably link out to the section that's being moved.

I strongly favor limiting How-to to plotting related topics. You can rephrase every aspect as a how-to ("how to install Matplotlib", "how to find examples", "how to view the documentation", ...) but IMHO that does not do much good. It only bloats the How-To, making relevant information harder to find. These topics should be easily accessible from the main page and/or by search. It's not too bad already, but there's still room for improvement, which I will target later with another PR.

@jklymak
jklymak requested a review from story645 August 14, 2020 16:09

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that How-to is the whole manual, and this How-to should be how-to do something as an end product, not "how to do some process". OTOH we could consider changing the name of this page, or getting rid of it entirely. It seems disorganized...

@timhoffm

Copy link
Copy Markdown
Member Author

I agree that this is disorganized - and probably wouldn't object removing it entirely. Though a How-To with carefully selected content would certainly be helpful.

Here and in the two previous PRs, I've taken the slow route of just stripping "How-to: Contributing" and making sure all removed information is easily accessible in the contribution guide.

More cleanup can always be done later.

@jklymak

jklymak commented Aug 17, 2020

Copy link
Copy Markdown
Member

@story645 you are blocking this still...

minor grammar edits
Sorry for committing directly, the new branch button 404s
@story645

Copy link
Copy Markdown
Member

Sorry, made some minor grammar changes directly, but will still approve if those are reverted

@jklymak

jklymak commented Aug 17, 2020

Copy link
Copy Markdown
Member

Merging improvement. Of course follow-up PRs are welcome....

@jklymak
jklymak merged commit d592ebb into matplotlib:master Aug 17, 2020
@timhoffm
timhoffm deleted the doc-how-to-contributing branch August 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants