Repository navigation
Add quick-link buttons for contributing - #17825
Merged
Merged
Conversation
Member
|
Instead of fixed width, can we do |
Contributor
|
Instead of changing from fixed width buttons to adding consistent padding, maybe change "contribute documentation" to "Write Documentation" It's quicker to read (smaller words! yay!) and ensures there's comfortable white space around the button text Edit: Also, not repeating the word "Contribute" will visually make the two buttons more distinctive |
timhoffm
force-pushed
the
doc-contribute-buttons
branch
from
July 4, 2020 21:20
7974795 to
e697abd
Compare
Member
Author
|
I've applied both; I'm not too worried about style anyway at the moment. This is intended as a first step in a series of PRs that reorganize parts of the docs and make relevant information easier accessible. It may well be that there is further fine-tuning down the road. |
tacaswell
approved these changes
Jul 5, 2020
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Jul 6, 2020
This was a regression of matplotlib#17825.
vrthra
pushed a commit
to uds-se/matplotlib
that referenced
this pull request
Jul 9, 2020
This was a regression of matplotlib#17825.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds button to the top of the Developers Guide:
Motivation
The Developers Guide is linked from "Contributing" in the main menu. The buttons provide quick links to the most common operations users want to do when contributing.
Technical notes
<span>s instead of<div>s. The button styling code is extracted to.mpl-buttonclass and separated from the layout (display/margin) of the donate button.