Repository navigation
Lower Text's FontProperties priority when updating - #16694
Merged
Merged
Conversation
anntzer
previously requested changes
Mar 6, 2020
anntzer
left a comment
anntzer
left a comment
Contributor
There was a problem hiding this comment.
This should not use an image comparison test (per https://matplotlib.org/devdocs/devel/testing.html#writing-an-image-comparison-test), but either use check_figures_equal or much more simply just check the resulting text object's properties.
Anyone can dismiss when handled.
Contributor
Author
|
@anntzer thank you for your feedback, I agree with the change you requested and have pushed a simpler unit test that asserts on the |
anntzer
approved these changes
Mar 6, 2020
timhoffm
reviewed
Mar 6, 2020
Contributor
Author
|
@timhoffm thank you for the good suggestion. I applied it. I think we're good to go, will it merge automatically? |
Co-authored-by: Robert Augustynowicz <[email protected]> Closes: matplotlib#16389
QuLogic
approved these changes
Mar 7, 2020
Member
|
Thanks @omarchehab98 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Robert Augustynowicz [email protected]
Closes: #16389
PR Summary
When
fontpropertiesis being used, it's default values are overwriting explicit font attributes such assize.Before
After
PR Checklist