Catch correct parse error type for dateutil >= 2.8.1#15729
Conversation
|
That looks like a bug in dateutil? (the exception is raised while trying to format the message for the actual exception...) Let's see whether @pganssle plans to fix that soon, if there's an (e.g.) 2.8.1.1 that fixes it perhaps we can just not support 2.8.1. |
|
I don't think this has been reported, do you have any details about how to trigger this? |
|
traceback is at #15726, sorry I don't have a minimal repro but the last line of the tb is |
|
Created an issue in dateutil/dateutil#981. Shouldn't be too tough to fix it. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
…729-on-v3.2.x Backport PR #15729 on branch v3.2.x (Catch correct parse errror type for dateutil >= 2.8.1)
…729-on-v3.1.x Backport PR #15729 on branch v3.1.x (Catch correct parse errror type for dateutil >= 2.8.1)
|
Doesn't need backport to 2.2.x because that code path did not exist there yet. |
PR Summary
Fixes #15726.
Backporting to 2.2.5 because dateutil 2.8.1 still supports Python 2.
Release critical because this execption is part of a standard code path (
_str_is_convertible()returningFalse).