Skip to content

Assume that mpl-data is in its standard location.#14401

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:datapath
Jun 8, 2019
Merged

Assume that mpl-data is in its standard location.#14401
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:datapath

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented May 31, 2019

The previous candidates tested in get_candidate_paths were for

  1. when matplotlib itself was a namespace package (a long time ago,
    before mpl_toolkits were move out of matplotlib proper), and
  2. py2exe support, which is deprecated (see deprecation of
    get_py2exe_datafiles).

Just to be sure in case someone else is relying on the paths in
get_candidate_paths, emit a deprecation warning in case they are needed,
but let's not bother with an API changes note (it's not even clear how
to word that).

Note that redistributors (e.g. linux distro packagers) who may want to
move mpl-data out can still do so by patching out the entire
_get_data_path function.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The previous candidates tested in get_candidate_paths were for

1) when matplotlib itself was a namespace package (a long time ago,
   before mpl_toolkits were move out of matplotlib proper), and
2) py2exe support, which is deprecated (see deprecation of
   get_py2exe_datafiles).

Just to be sure in case someone else is relying on the paths in
get_candidate_paths, emit a deprecation warning in case they are needed,
but let's not bother with an API changes note (it's not even clear how
to word that).

Note that redistributors (e.g. linux distro packagers) who may want to
move mpl-data out can still do so by patching out the entire
`_get_data_path` function.
@anntzer anntzer added this to the v3.2.0 milestone May 31, 2019
@tacaswell tacaswell merged commit 4f2ee1a into matplotlib:master Jun 8, 2019
@tacaswell
Copy link
Copy Markdown
Member

attn @sandrotosi @QuLogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants