Repository navigation
Conversation
ImportanceOfBeingErnest
force-pushed
the
fancyarrowpatch-joinstyle
branch
from
March 10, 2019 22:34
32140cb to
3304800
Compare
ImportanceOfBeingErnest
force-pushed
the
fancyarrowpatch-joinstyle
branch
from
March 10, 2019 22:40
3304800 to
77cdbe8
Compare
anntzer
approved these changes
Mar 11, 2019
Member
|
Would be nice to add a test; if you're happy @ImportanceOfBeingErnest I can try and push one to your branch. |
Member
Author
|
I wasn't sure what exactly to test here, because present tests do already implicitely check that |
Member
|
Hmm, this is more complicated than I thought! The change seems reasonable though, so I'll merge. |
dstansby
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Quick attempt to fix #13641
PR Checklist