Skip to content

Avoid private API in some examples. - #13202

Merged
anntzer merged 1 commit into
matplotlib:masterfrom
QuLogic:no-private-api
Jan 17, 2019
Merged

anntzer merged 1 commit into
matplotlib:masterfrom
QuLogic:no-private-api

Conversation

@QuLogic

@QuLogic QuLogic commented Jan 17, 2019

Copy link
Copy Markdown
Member

PR Summary

Refs #13199; all but the last are fixed.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Refs matplotlib#13199; all but the last are fixed.
@QuLogic QuLogic added this to the v3.1 milestone Jan 17, 2019


def add_inner_title(ax, title, loc, size=None, **kwargs):
def add_inner_title(ax, title, loc, **kwargs):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I removed size here because it was unused and didn't want to leave it cluttering up the example.

@anntzer

anntzer commented Jan 17, 2019

Copy link
Copy Markdown
Contributor

thanks!

@anntzer
anntzer merged commit 99af9e3 into matplotlib:master Jan 17, 2019
@QuLogic
QuLogic deleted the no-private-api branch January 17, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants