Skip to content

DOC: Adding example references for Shapes,Pie&Polar,Color sections - #11209

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
ImportanceOfBeingErnest:example-refs_shapes-coll-lines
May 10, 2018
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
ImportanceOfBeingErnest:example-refs_shapes-coll-lines

Conversation

@ImportanceOfBeingErnest

@ImportanceOfBeingErnest ImportanceOfBeingErnest commented May 9, 2018 •

Copy link
Copy Markdown
Member

PR Summary

This is part of creating backreferences for the examples.
as discussed in #11019 and #10148 and #10974.

This PR concerns the

  • Shapes & Collections
  • Pie & Polar
  • Color

sections of the gallery.

In addition,

  • the Color Demo example has been reworked to include all 8 possible ways to specify a color; and
  • the Ellipse Rotated example has been removed and its code incorporated into the Ellipse Demo example.

PR Checklist

  • Code is PEP 8 compliant
  • Documentation is sphinx and numpydoc compliant

@jklymak

jklymak commented May 9, 2018

Copy link
Copy Markdown
Member

OK, can someone smarter than me trace back when we lost codecov/project/tests coverage?

@jklymak jklymak added this to the v2.2-doc milestone May 9, 2018
@jklymak

jklymak commented May 9, 2018

Copy link
Copy Markdown
Member

Huh, mysteriously fixed!

@jklymak
jklymak merged commit 9ec4b95 into matplotlib:master May 10, 2018
@lumberbot-app

lumberbot-app Bot commented May 10, 2018

Copy link
Copy Markdown

There seem to be a conflict, please backport manually

@jklymak

jklymak commented May 10, 2018

Copy link
Copy Markdown
Member

OK, these are cool. Not sure I want to tackle backporting them though.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Jun 28, 2018
…ple-refs_shapes-coll-lines

DOC: Adding example references for Shapes,Pie&Polar,Color sections

Conflicts:
	examples/pie_and_polar_charts/pie_demo2.py

Removed all changes to pie_demo2.py because other changes to that
example on master branch exposes bugs that are present in 2.2.2
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Jun 28, 2018
…ple-refs_shapes-coll-lines

DOC: Adding example references for Shapes,Pie&Polar,Color sections

Conflicts:
	examples/pie_and_polar_charts/pie_demo2.py

Removed all changes to pie_demo2.py because other changes to that
example on master branch exposes bugs that are present in 2.2.2
@tacaswell tacaswell mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants