Repository navigation
Conversation
Member
|
This does not seem right as it is attaching units to the user input. It does not currently work if you pass in xmin/ymin with units (ex dates)? |
tacaswell
requested changes
Jan 1, 2018
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
In the case of axhline the xmin/xmax should be in axis fraction which I do not understand why this should have units attached to it.
I suspect this bug should be fixed a different way.
Member
|
@dstansby can you give us a non-astropy example that doesn't work? Maybe w/ dates as that is a readilly usable units for the rest of us... |
Member
Author
|
Yeah, sorry, I've had my head buried in astropy units recently, so this approach doesn't work generally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
axvlineandaxhlinework with units. I have checked this with astropy units (needs astropy/astropy#7037), but I'm not sure how to check it with other unit systems.