Unecessary arguement in GraphicsContextBase get_linestyle #3354

Activity

1. WeatherGod commented on Aug 8, 2014

   

   WeatherGod

   on Aug 8, 2014

   Member

   More actions

   Wow, how did we miss that? Double-check how you are making your PR,
   ensuring that it isn't against your own repo. Also, I noticed that you
   called your repo "jplotlib", so I don't know if that might have an impact
   or not.

   On Fri, Aug 8, 2014 at 10:49 AM, JamesRamm [email protected] wrote:

   There is an unnecessary arguement in get_linestyle of GraphicsContextBase.
   An unused arguement is required, which shouldn't be there.
   It blocks any future 'propertification'...

   I made the changes, but when trying to make a pull request against that
   commit, GitHub says there is nothing to compare?

   Here is the commit:
   JamesRamm/matplotlib@0bab982
   https://github.com/JamesRamm/jplotlib/commit/0bab98249ee1b966eac96ac295e0e613a279b1cd

   —
   Reply to this email directly or view it on GitHub
   #3354.
2. JamesRamm commented on Aug 8, 2014

   

   JamesRamm

   on Aug 8, 2014

   Author

   More actions

   I dont think jplotlib should make a difference (I changed the name of my fork to stop confusing myself!) it still has matplotlib as the master upstream...
   I am probably doing something wrong though...I am new to git and distributed source control in general...I'll give it another go...
3. tacaswell commented on Aug 8, 2014

   

   tacaswell

   on Aug 8, 2014

   Member

   More actions

   But it confuses us!
4. JamesRamm commented on Aug 9, 2014

   

   JamesRamm

   on Aug 9, 2014

   Author

   More actions

   :) well..I've put it back!

   I actually started all over again with a fresh fork...I'd made too many messups!

   So I've created a pull request for this issue:

   #3355
5. tacaswell commented on Aug 9, 2014

   

   tacaswell

   on Aug 9, 2014

   Member

   More actions

   git lets you name your remotes what ever you want, that is how I keep track of which is which (I actually have 10-15 remotes in my matplotlib repo named by user name).
6. tacaswell

   added this to the v1.5.xThis milestone has been deleted milestone on Aug 17, 2014
7. tacaswell

   added

   API: changesChanges to the public API, typically requiring deprecation.Changes to the public API, typically requiring deprecation.

   API: consistencyConsistency of the matplotlib API, including naming, behavior, defaults, …Consistency of the matplotlib API, including naming, behavior, defaults, …

   on Nov 26, 2014
8. petehuang commented on Dec 30, 2016

   

   petehuang

   on Dec 30, 2016

   Contributor

   More actions

   This one should be so easy :)

   #3355 had stalled due to some bad commit pulling. The issue still stands, and the fix is as following:

   1. Navigate to https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backend_bases.py#L915-L920
   2. Remove the style keyword from the signature
   3. Commit!

   I'd mark as new-contributor-friendly and Difficulty: Easy
9. NelleV

   closed this as completedin #7730on Jan 13, 2017