[Bug]: macOS backend UI doesn't update on 'o' and 'p' shortcuts #31933

Activity

1. QuLogic commented on Jun 23, 2026

   

   QuLogic

   on Jun 23, 2026

   Last edited by QuLogic

   Member

   More actions

   It looks like Qt just checks self.mode in pan and zoom after calling the superclass method:

   matplotlib/lib/matplotlib/backends/backend_qt.py

   Lines 901 to 914 in 1cba207

   	def _update_buttons_checked(self):
   	# sync button checkstates to match active mode
   	if 'pan' in self._actions:
   	self._actions['pan'].setChecked(self.mode.name == 'PAN')
   	if 'zoom' in self._actions:
   	self._actions['zoom'].setChecked(self.mode.name == 'ZOOM')
   	def pan(self, *args):
   	super().pan(*args)
   	self._update_buttons_checked()
   	def zoom(self, *args):
   	super().zoom(*args)
   	self._update_buttons_checked()

   On a related note, it looks like the macosx backend doesn't implement NavigationToolbar2.set_history_buttons.

   👍React with 👍1Reacted by Ricci Adams
2. QuLogic

   added

   GUI: MacOSX

   on Jun 23, 2026
3. iccir commented on Jun 23, 2026

   

   iccir

   on Jun 23, 2026

   ContributorAuthor

   More actions

   I got it fixed in my local branch by doing something similar:

       def _update_buttons_checked(self):
           mode_names = {_Mode.PAN: 'pan', _Mode.ZOOM: 'zoom'}
           self.update_selected_item(mode_names.get(self.mode, ''))
   
       def pan(self, *args):
           super().pan(*args)
           self._update_buttons_checked()
   
       def zoom(self, *args):
           super().zoom(*args)
           self._update_buttons_checked()

   Where self.update_selected_item() eventually calls into the Objective-C layer.

   Thanks for letting me know about set_history_buttons()! I'll get that wired up!
4. iccir commented on Jun 23, 2026

   

   iccir

   on Jun 23, 2026

   ContributorAuthor

   More actions

   (Ideally, I want to get rid of the hardcoded panButton and zoomButton in the Obj-C layer. I'm trying to follow the path that MEP22 lays out to make the eventual migration easier!)
5. iccir commented on Jun 27, 2026

   

   iccir

   on Jun 27, 2026

   ContributorAuthor

   More actions

   Fixed in my macosx-rework branch.