You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @EngineerKhan, I think either will work, but I agree this docstring should be self-consistent. Changing it as you say would make it match fig.add_axes (which it calls underneath). Would you like to make a PR?
@EngineerKhan it looks like you still need to create the pull request from your branch. If you go here then you should see a "New pull request" button.
Activity
rcomer commentedon Aug 12, 2023
Thanks @EngineerKhan, I think either will work, but I agree this docstring should be self-consistent. Changing it as you say would make it match fig.add_axes (which it calls underneath). Would you like to make a PR?
EngineerKhan commentedon Aug 13, 2023
@rcomer I have made the PR. Please check if it sounds good.
rcomer commentedon Aug 14, 2023
@EngineerKhan I cannot see a pull request from you.
EngineerKhan commentedon Aug 14, 2023
@rcomer Maybe I done it wrongly? Can you please check it again?
rcomer commentedon Aug 14, 2023
@EngineerKhan it looks like you still need to create the pull request from your branch. If you go here then you should see a "New pull request" button.
EngineerKhan commentedon Aug 14, 2023
@rcomer My bad. I have made one now. Hope it's the right way to do it.