You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Doc]: logo example should include dark option and have names #25537
We now have a dark version that should be in the logo example as a toggle.
The logo example should have "logo_light.svg" and "logo_dark.svg" somewhere in the text so its searchable by the name of the files that get used in the site logo.
Hello @jklymak, I just came across this issue and looked at the links you shared.
Do we want to add a new example altogether to highlight the creation of the dark mode logo too ?
Or should just having textual reference to suggest the existence of a dark themed logo do the trick?
Hello @jklymak , is this what you had in mind?
I have added a new parameter to the make_logo method called 'mode' which can be used to generate 2 different kinds of logo both the "logo_light.svg" and "logo_dark.svg" mainly because the hexcode color for the logo_light.svg was hard coded in the example.
We can incorporte this new example as seen in the screenshot to the matplotlib logo example, if you feel this seems good enough.
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!
Activity
kindler-king commentedon Apr 5, 2023
Hello @jklymak, I just came across this issue and looked at the links you shared.
Do we want to add a new example altogether to highlight the creation of the dark mode logo too ?
Or should just having textual reference to suggest the existence of a dark themed logo do the trick?
jklymak commentedon Apr 5, 2023
I'd have the example make both logos.
kindler-king commentedon Apr 10, 2023
Hello @jklymak , is this what you had in mind?
I have added a new parameter to the make_logo method called 'mode' which can be used to generate 2 different kinds of logo both the "logo_light.svg" and "logo_dark.svg" mainly because the hexcode color for the logo_light.svg was hard coded in the example.
We can incorporte this new example as seen in the screenshot to the matplotlib logo example, if you feel this seems good enough.
github-actions commentedon Jun 8, 2026
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!