Skip to content

[Doc]: logo example should include dark option and have names #25537

Open

Description

@jklymak

Documentation Link

https://github.com/matplotlib/matplotlib/blob/main/galleries/examples/misc/logos2.py

Problem

We now have a dark version that should be in the logo example as a toggle.

The logo example should have "logo_light.svg" and "logo_dark.svg" somewhere in the text so its searchable by the name of the files that get used in the site logo.

See matplotlib/mpl-sphinx-theme#62

Activity

  1. kindler-king commented on Apr 5, 2023

    @kindler-king

    Hello @jklymak, I just came across this issue and looked at the links you shared.
    Do we want to add a new example altogether to highlight the creation of the dark mode logo too ?
    Or should just having textual reference to suggest the existence of a dark themed logo do the trick?

  2. jklymak commented on Apr 5, 2023

    @jklymak
    MemberAuthor

    I'd have the example make both logos.

  3. kindler-king commented on Apr 10, 2023

    @kindler-king

    Hello @jklymak , is this what you had in mind?
    I have added a new parameter to the make_logo method called 'mode' which can be used to generate 2 different kinds of logo both the "logo_light.svg" and "logo_dark.svg" mainly because the hexcode color for the logo_light.svg was hard coded in the example.

    We can incorporte this new example as seen in the screenshot to the matplotlib logo example, if you feel this seems good enough.

    Screenshot from 2023-04-10 17-05-58

  4. github-actions commented on Jun 8, 2026

    @github-actions

    This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

  5. linked a pull request that will close this issueNew document page for logo usage guide #30631on Jun 8, 2026
  6. added
    keepItems to be ignored by the “Stale” Github Action
    and removed
    status: inactiveMarked by the “Stale” Github Action
    on Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DocumentationkeepItems to be ignored by the “Stale” Github Action

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions