Skip to content

Undefined names: 'obj_type' and 'cbook' #11550

Closed

Description

@cclauss

@anntzer I thought we had testing in place to catch these kind of errors before PR review.

flake8 testing of https://github.com/matplotlib/matplotlib on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./lib/matplotlib/__init__.py:917:31: F821 undefined name 'obj_type'
                version, key, obj_type, alternative=alt_key)
                              ^
./lib/matplotlib/gridspec.py:279:13: F821 undefined name 'cbook'
            cbook.warn_deprecated("2.2", "fig", obj_type="keyword argument",
            ^
./lib/matplotlib/gridspec.py:369:13: F821 undefined name 'cbook'
            cbook.warn_deprecated("2.2", "fig", obj_type="keyword argument",
            ^
3     F821 undefined name 'obj_type'
3

Activity

  1. anntzer commented on Jul 2, 2018

    @anntzer
    Contributor

    Well, I'm waiting for #11477 (comment) to be resolved...

  2. added 2 commits that reference this issue on Jul 7, 2018
    200c18f
    5e859f8
  3. added this to the v3.0 milestone on Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions