Skip to content

Unexpected behavior for Axes3D.plot_surface(shade=None) #11154

Closed

Description

@timhoffm

According to the docs the kwarg shade has to be a bool. The current implementation also accepts None and translates it to False.

Relevant code segment.

shade = kwargs.pop('shade', cmap is None)
if shade:

I assume that the current behavior is an unintended implementation detail, and I propose to change the semantics of shade=None to "use default" in order to allow further code simplification using default kwargs (#11145).

Activity

  1. WeatherGod commented on May 2, 2018

    @WeatherGod
    Member

    +1 on that idea.

  2. added this to the v3.1 milestone on Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions