Repository navigation
Put back the scrolling support - #109
Merged
Merged
Conversation
tacaswell
approved these changes
Jul 1, 2019
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
Thanks!
Not fully qualified to review the JS...
Member
Author
|
Tested with this example: https://gist.github.com/tacaswell/3144287 and it seems to work just fine :) |
Member
|
@tacaswell what is the way you would like to see this go? Should the ipympl widget always catch scroll events and we only process them in the backend if the user does something like in your example? |
Member
|
Yes, this is consistent with how the rest of the interactive backends handle scroll events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc. @tacaswell
As discussed here #81 (comment)