Skip to content

incompatibility with mpl 3.4 #309

Closed

Description

@tacaswell

Describe the issue

matplotlib/matplotlib#19146 made changes to how we encode keyboard events on the js side to ship back to the Python side.

This PR greatly improved the uniformity of handling the keyboard, but think we need to port the js side changes of https://github.com/matplotlib/matplotlib/pull/19146/files?file-filters%5B%5D=.js#diff-179115fdfd653499287a838c855c18302928eccf4d4878acb93da98701246d0d to ipympl or locally restore the old implementation of _handle_key.

Activity

  1. tacaswell commented on Mar 17, 2021

    @tacaswell
    MemberAuthor
    # %%
    
    %matplotlib widget
    import matplotlib.pyplot as plt
    import ipywidgets as widgets
    
    # %%
    
    fig, ax = plt.subplots()
    
    # %%
    out = []
    
    txt = widgets.Text()
    
    def handler(event):
        out.append(event)
        txt.value = event.key
    
    fig.canvas.mpl_connect('key_press_event', handler)
    
    display(txt)
  2. added 3 commits that reference this issue on Mar 17, 2021
    b38e8aa
    e7fe2ff
    aa4945b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions