Repository navigation
Drop the repeated previous_nb_actions key in DashboardTest - #25198
Merged
Merged
Conversation
sgiehl
added
the
c: Tests & QA
sgiehl
approved these changes
Sep 4, 2026
sgiehl
enabled auto-merge (squash)
September 4, 2026 12:39
maxtaube
pushed a commit
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'previous_nb_actions' => 0is written twice inside each of the three expected site arrays inDashboardTest, once next topreviousRangeand again down in theprevious_*block. PHP keeps the first position and the last value for a repeated key, so the second one has never changed what the array holds.I dropped the second occurrence rather than the first for that reason. The array that comes out is the same as before, both in values and in key order.
Checklist