Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: matklad/once_cell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.17.1
Choose a base ref
...
head repository: matklad/once_cell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.17.2
Choose a head ref
  • 10 commits
  • 7 files changed
  • 4 contributors

Commits on May 23, 2023

  1. clippy::mem_replace_with_default

    warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`
       --> src/lib.rs:641:13
        |
    641 |             mem::replace(self, Self::default()).into_inner()
        |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(self)`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default
        = note: `#[warn(clippy::mem_replace_with_default)]` on by default
    
    warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`
        --> src/lib.rs:1166:13
         |
    1166 |             mem::replace(self, Self::default()).into_inner()
         |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(self)`
         |
         = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default
    jqnatividad committed May 23, 2023
    Configuration menu
    Copy the full SHA
    885ab76 View commit details
    Browse the repository at this point in the history
  2. clippy::needless_borrow

    warning: this expression creates a reference which is immediately dereferenced by the compiler
       --> src/imp_std.rs:212:22
        |
    212 |                 wait(&queue, curr_queue);
        |                      ^^^^^^ help: change this to: `queue`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
        = note: `#[warn(clippy::needless_borrow)]` on by default
    jqnatividad committed May 23, 2023
    Configuration menu
    Copy the full SHA
    307ff0c View commit details
    Browse the repository at this point in the history
  3. clippy::redundant_pattern_matching

    warning: redundant pattern matching, consider using `is_err()`
       --> src/race.rs:354:20
        |
    354 |             if let Err(_) = exchange {
        |             -------^^^^^^----------- help: try this: `if exchange.is_err()`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
        = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
    jqnatividad committed May 23, 2023
    Configuration menu
    Copy the full SHA
    39933cd View commit details
    Browse the repository at this point in the history
  4. Merge #228

    228: Make clippy happy r=matklad a=jqnatividad
    
    applied select clippy lint recommendations
    
    Co-authored-by: Joel Natividad <[email protected]>
    bors[bot] and jqnatividad authored May 23, 2023
    Configuration menu
    Copy the full SHA
    652015f View commit details
    Browse the repository at this point in the history
  5. modernize docs

    closes #229
    matklad committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8c42266 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. Avoid unnecessary synchronization in {force,deref}_mut

      - `DerefMut` was not delegating to `force_mut()` (contary to the
        by-ref APIs);
      - `Lazy::force_mut` was not taking advantage of exclusive-mutability
        access, and instead paying shared-mutability access. Mainly, in the
        `sync` case, it involved atomic operations which are now skipped.
    
    Fixes #226
    danielhenrymantilla committed May 28, 2023
    Configuration menu
    Copy the full SHA
    8f2d2f5 View commit details
    Browse the repository at this point in the history
  2. v1.17.2

    danielhenrymantilla committed May 28, 2023
    Configuration menu
    Copy the full SHA
    b5db23c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53ac97e View commit details
    Browse the repository at this point in the history
  4. Update .lock file

    danielhenrymantilla committed May 28, 2023
    Configuration menu
    Copy the full SHA
    060943b View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge #231

    231: Avoid unnecessary synchronization in `{force,deref}_mut` r=matklad a=danielhenrymantilla
    
      - `DerefMut` was not delegating to `force_mut()` (contary to the by-ref APIs);
      - `Lazy::force_mut` was not taking advantage of exclusive-mutability access, and instead paying shared-mutability access. Mainly, in the `sync` case, it involved atomic operations which are now skipped.
    
    Fixes #226
    
    Co-authored-by: Daniel Henry-Mantilla <[email protected]>
    bors[bot] and danielhenrymantilla authored May 29, 2023
    Configuration menu
    Copy the full SHA
    8f39b77 View commit details
    Browse the repository at this point in the history
Loading