-
Notifications
You must be signed in to change notification settings - Fork 123
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: matklad/once_cell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.17.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: matklad/once_cell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.17.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 7 files changed
- 4 contributors
Commits on May 23, 2023
-
clippy::mem_replace_with_default
warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> src/lib.rs:641:13 | 641 | mem::replace(self, Self::default()).into_inner() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(self)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default = note: `#[warn(clippy::mem_replace_with_default)]` on by default warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> src/lib.rs:1166:13 | 1166 | mem::replace(self, Self::default()).into_inner() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(self)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_defaultConfiguration menu - View commit details
-
Copy full SHA for 885ab76 - Browse repository at this point
Copy the full SHA 885ab76View commit details -
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/imp_std.rs:212:22 | 212 | wait(&queue, curr_queue); | ^^^^^^ help: change this to: `queue` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by defaultConfiguration menu - View commit details
-
Copy full SHA for 307ff0c - Browse repository at this point
Copy the full SHA 307ff0cView commit details -
clippy::redundant_pattern_matching
warning: redundant pattern matching, consider using `is_err()` --> src/race.rs:354:20 | 354 | if let Err(_) = exchange { | -------^^^^^^----------- help: try this: `if exchange.is_err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by defaultConfiguration menu - View commit details
-
Copy full SHA for 39933cd - Browse repository at this point
Copy the full SHA 39933cdView commit details -
228: Make clippy happy r=matklad a=jqnatividad applied select clippy lint recommendations Co-authored-by: Joel Natividad <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 652015f - Browse repository at this point
Copy the full SHA 652015fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c42266 - Browse repository at this point
Copy the full SHA 8c42266View commit details
Commits on May 28, 2023
-
Avoid unnecessary synchronization in
{force,deref}_mut- `DerefMut` was not delegating to `force_mut()` (contary to the by-ref APIs); - `Lazy::force_mut` was not taking advantage of exclusive-mutability access, and instead paying shared-mutability access. Mainly, in the `sync` case, it involved atomic operations which are now skipped. Fixes #226Configuration menu - View commit details
-
Copy full SHA for 8f2d2f5 - Browse repository at this point
Copy the full SHA 8f2d2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5db23c - Browse repository at this point
Copy the full SHA b5db23cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53ac97e - Browse repository at this point
Copy the full SHA 53ac97eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 060943b - Browse repository at this point
Copy the full SHA 060943bView commit details
Commits on May 29, 2023
-
231: Avoid unnecessary synchronization in `{force,deref}_mut` r=matklad a=danielhenrymantilla - `DerefMut` was not delegating to `force_mut()` (contary to the by-ref APIs); - `Lazy::force_mut` was not taking advantage of exclusive-mutability access, and instead paying shared-mutability access. Mainly, in the `sync` case, it involved atomic operations which are now skipped. Fixes #226 Co-authored-by: Daniel Henry-Mantilla <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 8f39b77 - Browse repository at this point
Copy the full SHA 8f39b77View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.17.1...v1.17.2