src/garth/sso.py (1)

222-227: Consider narrowing the exception handling or adding logging.

The bare except GarthException: pass catches all HTTP errors (including 500s, network failures, auth issues), not just the 403 Cloudflare challenge mentioned in the comment. While the step is intentionally best-effort, silently swallowing all exceptions reduces observability for diagnosing unexpected failures.

Options to consider:

1. Check for specific 403 status and only suppress that
2. Add minimal logging (e.g., logger.debug) so failures are traceable

♻️ Option 1: Narrow to 403 only

     # Sets Cloudflare LB cookie for backend pinning — best-effort
     # (Cloudflare may challenge with 403 for bot detection)
     try:
         client.get("sso", "/portal/sso/embed")
-    except GarthException:
-        pass
+    except GarthHTTPError as e:
+        if e.error.response is not None and e.error.response.status_code == 403:
+            pass  # Expected Cloudflare challenge
+        else:
+            raise

♻️ Option 2: Log failures for observability

+import logging
+
+logger = logging.getLogger(__name__)
+
 # In _complete_login:
     try:
         client.get("sso", "/portal/sso/embed")
-    except GarthException:
-        pass
+    except GarthException as e:
+        logger.debug("Cloudflare LB cookie setup failed (non-blocking): %s", e)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/garth/sso.py` around lines 222 - 227, The try/except around
client.get("sso", "/portal/sso/embed") in sso.py currently swallows all
GarthException instances; narrow handling to only suppress Cloudflare 403s
and/or record failures: inspect the raised GarthException from client.get and if
its HTTP status is 403 only, suppress it; otherwise call the module logger
(e.g., logger.debug or logger.warning) with the exception details and re-raise
or handle appropriately so unexpected HTTP 5xx/network/auth errors are visible;
update the exception block referencing client.get and GarthException and use the
existing logger variable (or create one) to emit minimal observability.