Change Symbol to Token to avoid conflict with native Symbol in webpacked files. (mathjax/MathJax#3072) #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Aug 15, 2023
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
I did not review all files in detail. I built, tested in the lab and with my own test page. It works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Symbolclass name toTokenso that it doesn't conflict with the nativeSymbolobject in webpacked files. Webpacking of ESM files handles the exports from the componentlibfiles as global variables, and that means theSymbolobject will overwrite the native one, and since the webpack initialization code refers toSymbolbefore thatconst Symbolis set up, that cause a compile error. (The old CommonJSmodules.exportapproach didn't use separate global variables, so didn't have that problem.)Along with this, it renames
SymbolMaptoTokenMap, and changes variables calledsymboltotoken, where appropriate.Unfortunately, this touches a lot of files.
Resolves issue mathjax/MathJax#3072.