Skip to content

Fix bounding box computation for some embellished operators. (mathjax/MathJax#3250) #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpvc merged 1 commit into from
Jul 2, 2024
Merged

Fix bounding box computation for some embellished operators. (mathjax/MathJax#3250) #1114

dpvc merged 1 commit into from
Jul 2, 2024

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Jun 28, 2024

This PR fixes a bounding box computation for some embellished operators when inline breaking is enabled. For example:

<math xmlns="http://www.w3.org/1998/Math/MathML">
  <mn>1</mn>
  <mrow data-mjx-texclass="REL" mathbackground="red">
    <mover>
      <mo stretchy="false">&#x27F5;</mo>
      <mi>a</mi>
    </mover>
  </mrow>
  <mn>2</mn>
</math>

or

1 \style{background-color: red}{\stackrel{a}{\longleftarrow}} 2

will show the wrong sized red rectangle in SVG output when in-line breaking is enabled. This PR fixes that.

Resolves issue mathjax/MathJax#3250.

zorkow
zorkow approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 1c91d08 into develop Jul 2, 2024
@dpvc dpvc deleted the issue3250 branch July 2, 2024 12:28
@dpvc dpvc added this to the v4.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zorkow zorkow zorkow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dpvc @zorkow