Make textcomp package register with textmacros automatically. #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Mar 16, 2024
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
Question on priority. Otherwise looks fine.
| */ | ||
| export const TextBaseConfiguration = Configuration.create('text-base', { | ||
| parser: 'text', | ||
| priority: 1, |
Member
There was a problem hiding this comment.
Is there a reason for the priority?
Member
Author
There was a problem hiding this comment.
It was so that the base configuration is done first and then others that override anything in it don't need to specify their own priorities. But I think that the packages may be processed in reverse order, which means I should make this 10 instead.
Member
Author
There was a problem hiding this comment.
Just checked, and this does mean text-base will have its init() and config() methods called before the other configurations. So that means the default priority of 5 will put others after this, without having to set the priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the
textcomppackage to add itself to thetextmacrospackages automatically. In order to allow it to work with\require{textcomp}(and to work better with the Lab), we do this through theconfig()function of the configuration rather than setting it viaoptions. This is because when\require{textcomp}is processed, its dependecies are loaded and added to the configuration first, thentextcompis added. Becausetextmacrosis a dependency, it will be added and configured beforetextcompadds to thetextmacros.packagesif it is placed in theoptions.textmacros.packagesconfiguration option. Here, usingconfig(), we know thattextmacroswill already be configured, so we can add to thetextConfconfiguration directly.It may be possible to have
\requirecollect theconfig()methods from the dependencies and run them after all the initialization is done, but I didn't want to make that big a change here. This should the job for now.