Introduces a speechgenerator pool #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dpvc I've made the changes as discussed today. PTAL. |
dpvc
requested changes
Jan 29, 2024
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
I've made some comments about some minor issues. See what you think.
Member
Author
|
Incorporated the review suggestions. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces a
GeneratorPooldata structure thatThis makes the speech computation considerably cleaner. In particular there is no longer speech computation in the semantic enrichment method. Speech can be computed if the
speech="deep"option is set.All Speech is now computed in the
attachSpeechmethod, where originally only thearia-labelwas set.Since the
attachSpeechstate is called after rerender, this also takes care of computing speech for the collapsed elements etc.Another side effect is that we no longer use the walkers provided by SRE, which makes syncing a lot easier. At the moment only the walking and summary functionality is ported. The rest will be ported in a subsequent PR.
Note: Currently only works with SRE branch
new_explorer_changes. I'll try to merge that asap.