Fixes issue https://github.com/mathjax/MathJax/issues/3120 #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
requested changes
Dec 9, 2023
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
This fixes \_, but leaves the same potential problem for \^, if one were to be defined similarly to \_.
| } | ||
| if (node.attributes.get(TexConstant.Attr.LATEX) === '_' && str !== '_') { | ||
| if (node.attributes.get(TexConstant.Attr.LATEX) === '_' && | ||
| str !== '_' && str !== '\\_') { |
Member
There was a problem hiding this comment.
I think you need a similar fix for ^ in line 561 above, in case anyone creates a macro \^ similar to the \_ one.
Member
Author
There was a problem hiding this comment.
At the moment that can't really happen as latex computation happens after the macro replacement.
But I am not really happy with that anyway, so I've added the case.
PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MathJax issue #3120, by checking for the underscore command case.