Update CHTML longdiv output to not require clip-path. #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how CHTML handles the
longdivenclosure so that it doesn't need to use clipping paths. Apparently Chrome for Android and iOS only implementsclip-pathin very recent versions, and so older versions show a full oval rather than use the right half used for the division symbol. The solution is to break the half-oval into two parts: the upper and lower halves, and handle each separately. Each half uses a rounded corner of 100% radius (rather than the 50% radius that was used for the complete oval), with two of the border edges set tonone.