pnpm_move update #1023
Merged
pnpm_move update #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
reviewed
Nov 22, 2023
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
We could go one step further with our naming convention and do:
cjs:components:clean...
cjs:components:build...
...
cjs:bundle:clean ...
What do you think?
zorkow
requested changes
Nov 22, 2023
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
The \x1B change does not work for me. I'll look into it what we could use instead.
Member
@dpvc can you try this line, if the |
Member
Author
Sounds good. Go ahead with that.
Yes, it does. That was going to be my suggestion as well. |
Co-authored-by: Volker Sorge <[email protected]>
zorkow
approved these changes
Nov 23, 2023
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
Thanks. I'll go ahead and merge.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the changes that we discussed face-to-face:
The
makeAllscript is modified to not cd to the component directories, but rather passes the directory to the various programs as their last argument. This avoids the problem that you fixed in thepackcommand, in particular.The package scripts are modified:
\eescape is replaced by\x1Bsince MacOS ships with an older bash version that doesn't support that.log:single, and--was added to help make it visually distinct (especially whenlog:compis used before it)`.cjsandmjsnames were moved to the front of their commands to make the sections each use a prefix.mml3:prefix like the other sectionsbundle-cjsdirectory was moved earlier in thecleancommand so that the log messages are in a more appropriate order.