Skip to content

Comments

Add support for using the modularized passagemath distributions#3

Merged
mathehertogh merged 5 commits intomathehertogh:mainfrom
passagemath:passagemath
Jan 9, 2025
Merged

Add support for using the modularized passagemath distributions#3
mathehertogh merged 5 commits intomathehertogh:mainfrom
passagemath:passagemath

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 2, 2025

No description provided.

@mathehertogh
Copy link
Owner

Hi Matthias,

Cool that you want to add this functionality to passagemath. I designed and implemented this as a final project of my mathematics studies a few years ago. Since then I didn’t look much at this repo anymore. I was wondering: do you know of people using the package in practice?

Also: I uploaded this as a pip-package to some public distribution system (forgot all details by now). Apart from pulling in your import changes, would you need an “upgrade” of that pip-package also?

Regards, Mathé

@mathehertogh mathehertogh merged commit 50c363f into mathehertogh:main Jan 9, 2025
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 9, 2025

do you know of people using the package in practice?

Unfortunately I have no way of knowing.

I uploaded this as a pip-package to some public distribution system (forgot all details by now). Apart from pulling in your import changes, would you need an “upgrade” of that pip-package also?

Yes, that would be helpful as well! Better than telling people they have to pip-install from the git repository.

@mathehertogh
Copy link
Owner

Okay, was this pull request "all"? Or do you plan some more changes still?
Then I'll try to see if I can upload an updated version.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 9, 2025

Regarding code, it's complete. But if you want, I can send you a PR that adds instructions to the README similar to https://gitlab.com/modulispaces/admcycles/-/merge_requests/253/diffs

@mkoeppe mkoeppe deleted the passagemath branch January 10, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants