hide AssetManifest from flutter services imports #285
Merged
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
changed the title
guidezpl
approved these changes
Jan 26, 2023
Collaborator
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Thanks for the pre-emptive action
|
Do we need to publish this and update the benchmarks that use it? |
Contributor
Author
|
@jonahwilliams Yeah, we need to publish this and also update gallery to use the new version. @guidezpl, is there anything I can/need to do here to get this change published? |
Collaborator
|
I published |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flutter framework wishes to add a new class named
AssetManifestto its API (see flutter/flutter#119277). However, doing so would break integration tests that utilize google_fonts due to name collision with theAssetManifestclass that this package already defines (see flutter/flutter#119273).This PR adds
hide AssetManifestto thepackage:flutter/services.dartimports this package contains, which will allow the flutter framework to introduce this class without breaking its integration tests that utilize google_fonts.Once flutter's new
AssetManifestAPI is available, this package can be updated to use it instead of defining its own customAssetManifestclass, since flutter's will provide the same functionality and more.